[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1178128707.6183.6.camel@localhost.localdomain>
Date: Wed, 02 May 2007 10:58:27 -0700
From: john stultz <johnstul@...ibm.com>
To: Peter Keilty <peter.keilty@...com>
Cc: Daniel Walker <dwalker@...sta.com>, linux-ia64@...r.kernel.org,
Eric Whitney <eric.whitney@...com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] ia64: convert to use clocksource code
On Fri, 2007-04-27 at 12:11 -0400, Peter Keilty wrote:
> Daniel Walker wrote:
> >On Fri, 2007-04-27 at 11:42 -0400, Peter Keilty wrote:
> >>>There is a read(), and a vread() did you modify the slow syscall path to
> >>>use the vread()?
> >>>
> >John mentioned that he thought fsys_mmio_ptr could be held in the vread
> >pointer. vread() is used in x86 for vsyscalls. It looks like you've used
> >the update_vsyscall() which is also used for vsyscalls. So vread could
> >also be used .. Have you considered that at all?
> >
> >
> No, but yes it can be done, overloading the meaning.
Yea. I'm not really psyched about overloading the vread pointer's use. I
mentioned it could be done if the #ifdef was objected to, but it seems a
bit abusive. The #ifdef isn't great, but I think its something I can
live with for now. At least its explicit.
> It would need to change in the future if vread was needed.
> I have no strong argument against using it.
Yea. I'd hold off on that for now.
thanks
-john
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists