linux-kernel - Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 May 2007 23:35:38 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Stefan Richter" <stefanr@...6.in-berlin.de>
Cc:	linux-kernel@...r.kernel.org,
	"Kristian H??gsberg" <krh@...hat.com>,
	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	linux1394-devel <linux1394-devel@...ts.sourceforge.net>,
	"Christoph Hellwig" <hch@...radead.org>
Subject: Re: [PATCH 1/6] firewire: handling of cards, buses, nodes

On 5/2/07, Stefan Richter <stefanr@...6.in-berlin.de> wrote:
> I looked around a bit with grep -R and a few search terms but didn't
> find something definite.  Is there any other user of a crc16_itu_t or
> crc_ccitt or whatever which operates on a (CPU byte ordered) u32[]
> instead of on a (network byte ordered) u8[]?

I was referring to this: http://lkml.org/lkml/2006/6/12/137

On 5/2/07, Stefan Richter <stefanr@...6.in-berlin.de> wrote:
> The only value in having a shared implementation would be a potentially
> smaller kernel.  Sharing it to ensure correctness is not an issue;
> fw-topology.c::crc16_itu_t is simply the one in IEEE 1212 table 5.
> Performance is also not an issue (if better algorithms exist) because
> the FireWire stack uses it only infrequently on a moderate amount of data.

Yeah, it's not a biggie, but we do have a tradition of putting
generally useful things into lib/ so that everyone doesn't invent
their own.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/