linux-kernel - Re: [PATCH 2.6.21 2/3] x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705022255.37791.ak@suse.de>
Date:	Wed, 2 May 2007 22:55:37 +0200
From:	Andi Kleen <ak@...e.de>
To:	Chandramouli Narayanan <mouli@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 2.6.21 2/3] x86_64: EFI64 support


>  		if (type && ei->type != type) 
> @@ -148,6 +178,29 @@ int __init e820_all_mapped(unsigned long
>  unsigned long __init find_e820_area(unsigned long start, unsigned long end, unsigned size) 
>  { 
>  	int i; 
> +	if (efi_enabled) {
> +		efi_memory_desc_t *md;

Please convert the memory map from EFI into the e820 map in one place. This
would avoid all these weird special cases. Also custom memory map would
just work then.

I know i386 doesn't do it this way, but it's wrong and we'll eventually
fix it there too.

Also you have a few arbitary and white space changes in there that should be removed.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/