linux-kernel - Re: [PATCH] kernel option CONFIG_USB_HIDINPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705030951520.16923@twin.jikos.cz>
Date:	Thu, 3 May 2007 09:56:47 +0200 (CEST)
From:	Jiri Kosina <jikos@...os.cz>
To:	Noèl Köthe <noel@...ian.org>
cc:	linux-usb-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel option CONFIG_USB_HIDINPUT_POWERBOOK description
 update

On Wed, 2 May 2007, No?l Köthe wrote:

> The description of this option needs to be extended to be correct:)
> --- /usr/src/linux-2.6.21/drivers/usb/input/Kconfig     2007-04-27 18:02:46.000000000 +0200
> +++ Kconfig.new 2007-05-02 16:47:56.000000000 +0200
> @@ -28,12 +28,12 @@
>         depends on USB_HID && INPUT=n
>  
>  config USB_HIDINPUT_POWERBOOK
> -       bool "Enable support for iBook/PowerBook special keys"
> +       bool "Enable support for iBook/PowerBook/MacBook/MacBookPro special keys"

Hi,

I will apply this into my tree, thanks.

> This option is needed on the Apple Intel Laptops, too. I would suggest 
> to rename USB_HIDINPUT_POWERBOOK because its needed on Apple Laptops. 
> Maybe USB_HIDINPUT_APPLELAPTOPS or something like this. Is a renaming 
> patch for this welcome?

The problem here is backwards compatibility - if we would like to do the 
change in a consistent way, we should rename all the places which (for 
historic reasons) mention powerbook only. Unfortunately this would also 
require renaming the module parameter hid_pb_fnmode, which might be a 
little too intrusive with respect to maintaining backward compatibility in 
userspace (ok, we have already been fiddling with this parameter anyway 
during the usbhid code split, but anyway).

If you would care to make the patch which maintains backwards 
compatibility (for example by aliasing the variable pb_fnmode behing two 
module parameters), that might probably be ok.

Thanks,

-- 
Jiri Kosina