[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200705022238.36454.dtor@insightbb.com>
Date: Wed, 2 May 2007 22:38:35 -0400
From: Dmitry Torokhov <dtor@...ightbb.com>
To: Jan Kratochvil <honza@...os.cz>
Cc: Greg Kroah-Hartman <gregkh@...e.de>,
linux-input@...ey.karlin.mff.cuni.cz,
linux-usb-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH 1/3] xpad.c: Added flags into xpad_device structure and removed dpad_mapping.
Hi Jan,
On Wednesday 02 May 2007 11:01, Jan Kratochvil wrote:
> This changes are expected to simplify further improves of this driver,
> We will need to add information if the driver is xbox360 device or not.
>
> Second option was to simply add u8 is_360, but what if we'll need to know
> if device is a wheel? Or if the device can have keyboard (or headset) attached.
>
...
> -#define MAP_DPAD_TO_BUTTONS 0
> -#define MAP_DPAD_TO_AXES 1
> -#define MAP_DPAD_UNKNOWN -1
> +#define XPAD_FLAGS_DPAD_TO_BUTTONS (1 << 0)
> +#define XPAD_FLAGS_DPAD_TO_AXES (1 << 1)
> +#define XPAD_FLAGS_DPAD_UNKNOWN (1 << 2)
>
Turning this into bitmaps suggests that all of these could be set which is
not the case. Since there are 3 spare bytes in xpad_device structure to
use for additional flags/bitmaps I'd leave dpad_mapping alone.
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists