linux-kernel - Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 3 May 2007 17:43:38 +0200
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linuxppc-dev@...abs.org, linux-kernel@...r.kernel.org,
	linux-pcmcia@...ts.infradead.org
Subject: Re: [PATCH] [POWERPC] 8xx: mpc885ads pcmcia support

>> +               pcmcia@...0 {

>> +                       compatible = "8xx";

> The compatible property should be a little more specific, imho. Since 
> there
> are differences in how things are done depending on the board, it 
> would be
> good to tell the exact method from the pcmcia node itself.

Just "8xx" isn't good enough -- at a very minimum it
needs to say this is a PCMCIA controller!

> For example, you could make this
>
> 	compatible = "8xx\0mpc885ads";

"mpc885ads-pcmcia\0mpc8xx-pcmcia" or something like that.


Segher

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/