[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070503111628.c009af15.rdunlap@xenotime.net>
Date: Thu, 3 May 2007 11:16:28 -0700
From: Randy Dunlap <rdunlap@...otime.net>
To: "Robert P. J. Day" <rpjday@...dspring.com>,
jgarzik <jgarzik@...ox.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...l.org>
Subject: Re: Remove apparently dead CONFIG_NO_ATA_LEGACY code.
On Thu, 3 May 2007 13:53:06 -0400 (EDT) Robert P. J. Day wrote:
>
> Remove the single snippet of code conditional on the non-existent
> CONFIG_NO_ATA_LEGACY Kconfig variable.
>
> Signed-off-by: Robert P. J. Day <rpjday@...dspring.com>
>
> ---
>
> i would have mailed a note about this to the ATA maintainer but it
> wasn't clear who that was. this is the only dead CONFIG_ variable
> under drivers/ata so i figured i'd just submit the patch.
from that source file:
* Maintained by: Jeff Garzik <jgarzik@...ox.com>
* Please ALWAYS copy linux-ide@...r.kernel.org
* on emails.
> diff --git a/drivers/ata/libata-sff.c b/drivers/ata/libata-sff.c
> index d211db6..5a4821a 100644
> --- a/drivers/ata/libata-sff.c
> +++ b/drivers/ata/libata-sff.c
> @@ -985,16 +985,6 @@ int ata_pci_init_one (struct pci_dev *pdev, struct ata_port_info **port_info,
> mask = (1 << 2) | (1 << 0);
> if ((tmp8 & mask) != mask)
> legacy_mode = (1 << 3);
> -#if defined(CONFIG_NO_ATA_LEGACY)
> - /* Some platforms with PCI limits cannot address compat
> - port space. In that case we punt if their firmware has
> - left a device in compatibility mode */
> - if (legacy_mode) {
> - printk(KERN_ERR "ata: Compatibility mode ATA is not supported on this platform, skipping.\n");
> - rc = -EOPNOTSUPP;
> - goto err_out;
> - }
> -#endif
> }
>
> /* alloc and init host */
> --
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists