[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d120d5000705031206l2c675c22t5aab3eb648aa1cf8@mail.gmail.com>
Date: Thu, 3 May 2007 15:06:54 -0400
From: "Dmitry Torokhov" <dmitry.torokhov@...il.com>
To: "Michael Schmitz" <schmitz@...l.biophys.uni-duesseldorf.de>
Cc: "Geert Uytterhoeven" <geert@...ux-m68k.org>,
"Linus Torvalds" <torvalds@...ux-foundation.org>,
"Andrew Morton" <akpm@...ux-foundation.org>,
linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
"Michael Schmitz" <schmitz@...ian.org>,
"Roman Zippel" <zippel@...ux-m68k.org>
Subject: Re: [patch 04/33] m68k: Atari keyboard and mouse support.
Hi Michael,
On 5/3/07, Michael Schmitz <schmitz@...l.biophys.uni-duesseldorf.de> wrote:
> >
> > > +
> > > + if (!(atakbd_dev = input_allocate_device()))
> > > + return -ENOMEM;
> > > +
> > > + // need to init core driver if not already done so
> > > + if (atari_keyb_init())
> >
> > Memory leak
>
> How so? If the core has been initialized already this will just return ...
>
You just allocated atakbd_dev. If atari_keyb_init() fails you leak it.
> > > + for (i = 1; i < 0x72; i++) {
> > > + atakbd_keycode[i] = i;
> > > + set_bit(atakbd_keycode[i], atakbd_dev->keybit);
> >
> > It looks like this driver is not using standard input event codes. If
> > Roman does not want to adjust keymaps on Amiga and Atari that should
> > be handled in legacy keyboard driver (drivers/char/keyboard.c). As it
> > is programs using /dev/input/eventX have no chance of working.
>
> The translation map should not have been overwritten like above, is that
> what you mean?
> My original patch didn't have that bit; scancodes were translated to
> input keycodes using atakbd_keycode[scancode] instead. I'll have that
> reverted...
>
Does KEY_1 actually maps to scancode 2 on atari?
Thanks,
--
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists