linux-kernel - Re: [PATCH -rt] wrong usage of smp_processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 May 2007 13:21:47 -0700
From:	Daniel Walker <dwalker@...sta.com>
To:	Steven Rostedt <srostedt@...hat.com>
Cc:	mingo@...e.hu, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -rt] wrong usage of smp_processor_id()

On Thu, 2007-05-03 at 16:12 -0400, Steven Rostedt wrote:
> Daniel Walker wrote:
> 
> > ---
> >  kernel/latency_trace.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > Index: linux-2.6.21/kernel/latency_trace.c
> > ===================================================================
> > --- linux-2.6.21.orig/kernel/latency_trace.c
> > +++ linux-2.6.21/kernel/latency_trace.c
> > @@ -105,7 +105,7 @@ static inline int DEBUG_WARN_ON(int cond
> >  #ifdef CONFIG_CRITICAL_IRQSOFF_TIMING
> >  # ifdef CONFIG_CRITICAL_PREEMPT_TIMING
> >     static DEFINE_PER_CPU(int, trace_cpu_idle);
> > -#  define irqs_off_preempt_count() (!__get_cpu_var(trace_cpu_idle) && preempt_count())
> > +#  define irqs_off_preempt_count() (preempt_count() && !__get_cpu_var(trace_cpu_idle))
> >  # else
> >  #  define irqs_off_preempt_count() 0
> >  # endif
> 
> Ingo,
> 
> This is on top of one of my patches that I sent you (the cpu idle one). 
> So it's not for the 2.6.21-rt1, but if you apply my patch, this needs to 
> be added too.

Isn't it a generic problem? It doesn't look specific to your change
unless you made some changes to entry.S .

Daniel

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/