linux-kernel - Re: [PATCH 6/6] firewire: add it all to kbuild

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070503041543.GA12644@uranus.ravnborg.org>
Date:	Thu, 3 May 2007 06:15:43 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, Kristian H??gsberg <krh@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux1394-devel <linux1394-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 6/6] firewire: add it all to kbuild

On Thu, May 03, 2007 at 01:01:08AM +0200, Stefan Richter wrote:
> Christoph Hellwig wrote:
> >> +fw-core-objs := fw-card.o fw-topology.o fw-transaction.o fw-iso.o \
> >> +	fw-device.o fw-cdev.o
> > 
> > fw-core-y += ..
> > 
> 
> Like such?
Yes - the latter is much more readable.

	Sam

> 
> --- linux.orig/drivers/usb/core/Makefile
> +++ linux/drivers/usb/core/Makefile
> @@ -2,17 +2,12 @@
>  # Makefile for USB Core files and filesystem
>  #
> 
> -usbcore-objs	:= usb.o hub.o hcd.o urb.o message.o driver.o \
> +usbcore-y	+= usb.o hub.o hcd.o urb.o message.o driver.o \
>  			config.o file.o buffer.o sysfs.o endpoint.o \
>  			devio.o notify.o generic.o quirks.o
> 
> -ifeq ($(CONFIG_PCI),y)
> -	usbcore-objs	+= hcd-pci.o
> -endif
> -
> -ifeq ($(CONFIG_USB_DEVICEFS),y)
> -	usbcore-objs	+= inode.o devices.o
> -endif
> +usbcore-$(CONFIG_PCI)		+= hcd-pci.o
> +usbcore-$(CONFIG_USB_DEVICEFS)	+= inode.o devices.o
> 
>  obj-$(CONFIG_USB)	+= usbcore.o
> 
> 
> -- 
> Stefan Richter
> -=====-=-=== -=-= ---==
> http://arcgraph.de/sr/
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/