[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070503165800.5b7cd3fd.akpm@linux-foundation.org>
Date: Thu, 3 May 2007 16:58:00 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Stas Sergeev <stsp@...et.ru>
Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>,
Linux kernel <linux-kernel@...r.kernel.org>,
Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [patch] export hrtimer_forward
On Thu, 03 May 2007 23:10:02 +0400
Stas Sergeev <stsp@...et.ru> wrote:
> Hello.
>
> Peter Zijlstra wrote:
> >> It seems hrtimer_forward was forgotten to
> >> export - other symbols of the hrtimers API
> > Are there actual in-tree users of this symbol? Without we usually leave
> > the symbol unexported, this saves some space.
> Do you mean it was really left intentional?
> Unbeleivable! But why the other parts of a
> hrtimer API are exported nevertheless, and
> only this particular function not?
It was probably an oversight - generally we take the position that all the
formal interface of a subsystem is exported to modules rather than a
piecemeal whichever-bits-kernel.org-happens-to-use-today approach.
Thomas, is hrtimer_forward() considered part of the hrtimer public API?
And are you OK with the patch?
> As for the users - I am porting my pcsp driver to
> it and I need that function.
> It is not exactly in-tree stuff, but it was
> in an ALSA tree for years already, so it is a
> close one.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists