linux-kernel - Re: [PATCH] synclink_gt use dynamic tty device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070503000528.7d841ecc.akpm@linux-foundation.org>
Date:	Thu, 3 May 2007 00:05:28 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Paul Fulghum <paulkf@...rogate.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] synclink_gt use dynamic tty device registration

On Wed, 02 May 2007 11:17:33 -0500 Paul Fulghum <paulkf@...rogate.com> wrote:

> Change synclink_gt driver to use dynamic tty device registration.
> 
> ...
>
> +	for (i=0; i < port_count; ++i)
> +		tty_register_device(serial_driver, port_array[i]->line, &(port_array[i]->pdev->dev));
> ...
> +		for (info=slgt_device_list ; info != NULL ; info=info->next_device)
> +			tty_unregister_device(serial_driver, info->line);
> ...
> +	if ((rc = pci_register_driver(&pci_driver)) < 0) {

hm, not a big fan of kernel coding style, I see.

What's going to happen here if tty_register_device() fails?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/