linux-kernel - Re: [PATCH v2] lib/hexdump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705041431390.16844@blonde.wat.veritas.com>
Date:	Fri, 4 May 2007 14:41:38 +0100 (BST)
From:	Hugh Dickins <hugh@...itas.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>, jwboyer@...ux.vnet.ibm.com,
	grant.likely@...retlab.ca, jketreno@...ux.intel.com
Subject: Re: [PATCH v2] lib/hexdump

On Thu, 3 May 2007, Randy Dunlap wrote:
> 
> Example output using %DUMP_PREFIX_OFFSET:
> 0009ab42: 40414243 44454647 48494a4b 4c4d4e4f-@...DEFG HIJKLMNO
                                               ^        ^
> Example output using %DUMP_PREFIX_ADDRESS:
> ffffffff88089af0: 70717273 74757677 78797a7b 7c7d7e7f-pqrstuvw xyz{|}~.
                                                       ^        ^
I see that hyphen as joining together two unlike fields rather than
separating them: maybe change it to a couple of spaces?  And the space
halfway through the string is more interfering than helpful (when that
field is useful, it's a string: which shouldn't have a spurious space
inserted).  Otherwise looks nice to me.

Hugh
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/