linux-kernel - Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 4 May 2007 17:34:46 +0200
From:	Eric Dumazet <dada1@...mosbay.com>
To:	James Pearson <james-p@...ing-picture.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Don't truncate /proc/PID/environ at 4096 characters

On Fri, 04 May 2007 15:30:57 +0100
James Pearson <james-p@...ing-picture.com> wrote:

> /proc/PID/environ currently truncates at 4096 characters, patch based on 
> the /proc/PID/mem code.
> 
> Signed-off-by: James Pearson <james-p@...ing-picture.com>
>

What about latency when reading one *big* environ ?

Dont we need some cond_resched() test in the loop ?

> +
> +static struct file_operations proc_environ_operations = {
> +       .read           = environ_read,
> +};
> +

Please use the const qualifier here :

static const struct file_operations ...

Thank you

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/