linux-kernel - Re: [RFC/PATCH] ext3: remove inode constructor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705040907180.21436@schroedinger.engr.sgi.com>
Date:	Fri, 4 May 2007 09:08:25 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Pekka J Enberg <penberg@...helsinki.fi>
cc:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	sct@...hat.com, akpm@...ux-foundation.org, adilger@...sterfs.com
Subject: Re: [RFC/PATCH] ext3: remove inode constructor

On Fri, 4 May 2007, Pekka J Enberg wrote:

> Index: 2.6/fs/ext3/super.c
> ===================================================================
> --- 2.6.orig/fs/ext3/super.c	2007-05-04 12:57:09.000000000 +0300
> +++ 2.6/fs/ext3/super.c	2007-05-04 13:01:27.000000000 +0300
> @@ -444,17 +444,26 @@ static struct kmem_cache *ext3_inode_cac
>  static struct inode *ext3_alloc_inode(struct super_block *sb)
>  {
>  	struct ext3_inode_info *ei;
> +	struct inode *inode;
>  
>  	ei = kmem_cache_alloc(ext3_inode_cachep, GFP_NOFS);
>  	if (!ei)
>  		return NULL;
> +        INIT_LIST_HEAD(&ei->i_orphan);
> +#ifdef CONFIG_EXT3_FS_XATTR
> +        init_rwsem(&ei->xattr_sem);
> +#endif
> +        mutex_init(&ei->truncate_mutex);

^^^ whitespace issues

Also could this be generalized to also apply to the generic inode 
allocation in fs/inode.c?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/