linux-kernel - Re: [PATCH -mm] PM: Separate hibernation code from suspend code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0705041022jdc163fg20882d450338fb53@mail.gmail.com>
Date:	Fri, 4 May 2007 22:52:08 +0530
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Johannes Berg" <johannes@...solutions.net>,
	LKML <linux-kernel@...r.kernel.org>,
	"Pavel Machek" <pavel@....cz>,
	"Nigel Cunningham" <nigel@...el.suspend2.net>,
	"Pekka Enberg" <penberg@...helsinki.fi>
Subject: Re: [PATCH -mm] PM: Separate hibernation code from suspend code

Trivial suggestions:

On 5/4/07, Rafael J. Wysocki <rjw@...k.pl> wrote:
> --- linux-2.6.21.orig/include/linux/suspend.h   2007-05-02 22:08:58.000000000 +0200
> +++ linux-2.6.21/include/linux/suspend.h        2007-05-03 15:22:24.000000000 +0200
> [...]
> +/**
> + * hibernation_set_ops - set the global hibernate operations
> + * @ops: the hibernation operations to use in subsequent hibernation transitions
> + */
> +extern void hibernation_set_ops(struct hibernation_ops *ops);

Comment must go near code, not with prototype in header.

> +/**
> + * hibernate - hibernate the system
> + */
> +extern int hibernate(void);

Pointless comment. You've already written a doc-book comment in the
code for this function anyway, so could just as well remove this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/