linux-kernel - Re: patch: VFS: fix passing of AT_PHDR value in auxv to ELF interpreter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463BC265.7050507@goop.org>
Date:	Fri, 04 May 2007 16:31:49 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Quentin Godfroy <godfroy@...pper.ens.fr>
CC:	linux-kernel@...r.kernel.org,
	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	"David A. Madore" <David.Madore@....fr>,
	"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: patch: VFS: fix passing of AT_PHDR value in auxv to ELF interpreter

Quentin Godfroy wrote:
> +	elf_ppnt = elf_phdata;
> +	for (i = 0; i< loc->elf_ex.e_phnum; i++, elf_ppnt++)
> +		if (elf_ppnt->p_type == PT_PHDR) {
> +			phdr_addr = elf_ppnt->p_vaddr;
>   

Won't this break with ET_DYN executables?  And besides, isn't this the
same thing?  Shouldn't PT_PHDR->p_vaddr point to the vaddr of the Phdr
table itself?

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/