linux-kernel - Re: [PATCH 1/4] fs: Introduce path_component

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070506111412.GC1211@infradead.org>
Date:	Sun, 6 May 2007 12:14:12 +0100
From:	Christoph Hellwig <hch@...radead.org>
To:	Josef 'Jeff' Sipek <jsipek@...sunysb.edu>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	hch@...radead.org, akpm@...ux-foundation.org,
	viro@....linux.org.uk, Trond.Myklebust@...app.com, neilb@...e.de,
	mhalcrow@...ibm.com
Subject: Re: [PATCH 1/4] fs: Introduce path_component_lookup

I wrote up the suggestion before my first morning tea yesterday
and must admit that the name path_component_lookup is pretty stupid.
We don't just look up a component but any relative path starting
from the vfsmount/dentry pair.  How about vfs_path_lookup instead
because it mirrors various other vfs_ function that are dentry based?

Also as a new exported symbol it should get a kerneldoc comment describing
it.

> +	if (likely(retval == 0)) {
> +		if (unlikely(!audit_dummy_context() && nd && nd->dentry && 
> +				nd->dentry->d_inode))
> +			audit_inode(name, nd->dentry->d_inode);
> +	}

This should get the same simplification I suggested for do_path_lookup.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/