lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 06 May 2007 10:46:34 -0400 From: Trond Myklebust <Trond.Myklebust@...app.com> To: "Josef 'Jeff' Sipek" <jsipek@...sunysb.edu> Cc: linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, hch@...radead.org, akpm@...ux-foundation.org, viro@....linux.org.uk, neilb@...e.de, mhalcrow@...ibm.com Subject: Re: [PATCH 1/1] sunrpc: Use path_component_lookup On Sat, 2007-05-05 at 20:52 -0400, Josef 'Jeff' Sipek wrote: > use path_component_lookup instead of open-coding the necessary > functionality. > > Signed-off-by: Josef 'Jeff' Sipek <jsipek@...sunysb.edu> > --- > net/sunrpc/rpc_pipe.c | 16 +++++++--------- > 1 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/net/sunrpc/rpc_pipe.c b/net/sunrpc/rpc_pipe.c > index 9b9ea50..c93a454 100644 > --- a/net/sunrpc/rpc_pipe.c > +++ b/net/sunrpc/rpc_pipe.c > @@ -451,21 +451,19 @@ void rpc_put_mount(void) > static int > rpc_lookup_parent(char *path, struct nameidata *nd) > { > + struct vfsmount *mnt; > + > if (path[0] == '\0') > return -ENOENT; > - nd->mnt = rpc_get_mount(); > - if (IS_ERR(nd->mnt)) { > + > + mnt = rpc_get_mount(); > + if (IS_ERR(mnt)) { > printk(KERN_WARNING "%s: %s failed to mount " > "pseudofilesystem \n", __FILE__, __FUNCTION__); > - return PTR_ERR(nd->mnt); > + return PTR_ERR(mnt); > } > - mntget(nd->mnt); > - nd->dentry = dget(rpc_mount->mnt_root); > - nd->last_type = LAST_ROOT; > - nd->flags = LOOKUP_PARENT; > - nd->depth = 0; > > - if (path_walk(path, nd)) { > + if (path_component_lookup(mnt->mnt_root, mnt, path, LOOKUP_PARENT, nd)) { > printk(KERN_WARNING "%s: %s failed to find path %s\n", > __FILE__, __FUNCTION__, path); > rpc_put_mount(); Thanks! That looks good. Acked-by: Trond Myklebust <Trond.Myklebust@...app.com> Cheers Trond - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists