linux-kernel - Re: [RFC] [Patch 3/3] readahead statistics slimmed down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <463F1F11.8060508@de.ibm.com>
Date:	Mon, 07 May 2007 14:44:01 +0200
From:	Martin Peschke <mp3@...ibm.com>
To:	Fengguang Wu <fengguang.wu@...il.com>
CC:	linux-kernel@...r.kernel.org, linux-s390@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Fengguang Wu <wfg@...l.ustc.edu.cn>, swen@...t.ibm.com
Subject: Re: [RFC] [Patch 3/3] readahead statistics slimmed down

Fengguang Wu wrote:
> 2007/5/3, Martin Peschke <mp3@...ibm.com>:
>>
>> This patch implements the bulk of the existing the adaptive readahead
>> statistics with lib/statistics.c.
>>
>> The output format differs somewhat as the the statistics code just emits
>> lists of items and doesn't do tables. It is feasible to leave
>> reformating and beautification to some user scripts, if needed. This
>> patch omits some summary data, most of which can be done in user space
>> as well.
>>
>> Sample output (from dd'ing a disk):
>>
>> cache_miss.total 0 0
>> cache_miss.initial 0 0
>> cache_miss.clock 10 10
>> cache_miss.context 0 0
> 
> 
> Martin,
> 
> The new form of readahead statistics is appreciated. The code is much
> simpler and the output is suitable for scripting. Thank you for doing the
> conversion.
> 
> Me too have trimmed out the original ra_events_show() stuff based on your
> patches. However, later on it becomes obvious that the current adaptive
> readahead patch needs non-trivial rework. So the accounting patches were 
> put
> off. Expect to see them in the adaptive readahead kernel module ;-)
> 
> Thank you,
> Fengguang Wu

I have been wondering whether this one might be worth staging in -mm along with 
the other readahead patches. It would be work be work in progress like the other 
readahead patches. But I leave this decision to you and Andrew.

THanks for the positive feedback.

Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/