linux-kernel - Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1178543543.6158.7.camel@heimdal.trondhjem.org>
Date:	Mon, 07 May 2007 09:12:23 -0400
From:	Trond Myklebust <trond.myklebust@....uio.no>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	David Howells <dhowells@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>, davem@...emloft.net,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [-mm patch] fix fs/nfs/nfsroot.c compile error

On Mon, 2007-05-07 at 12:56 +0200, Adrian Bunk wrote:
> On Mon, May 07, 2007 at 11:47:51AM +0100, David Howells wrote:
> > Adrian Bunk <bunk@...sta.de> wrote:
> > 
> > > match_table_t was made "const" and gcc doesn't like "const __initdata":
> > 
> > Hmmm...  My gcc seems quite happy with it.  What gcc are you using?
> 
> 4.1
> 
> > Shouldn't __initdata override const?
> > 
> > > BTW: Why is this change to include/linux/parser.h in the net tree?
> > 
> > Because DaveM picked it up as part of my AFS patches, I guess.
> 
> It might make sense, but it doesn't seem to be in any way AFS specific.

It makes little or no sense to be forcing attributes like 'const' in a
typedef. That is basically stating that it is inconceivable to use
anything else. Clearly not the case here...

Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/