| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <m3k5vkfj6q.fsf@maximus.localdomain> Date: Mon, 07 May 2007 22:54:53 +0200 From: Krzysztof Halasa <khc@...waw.pl> To: Roman Zippel <zippel@...ux-m68k.org> Cc: Jeff Garzik <jeff@...zik.org>, Russell King <rmk@....linux.org.uk>, lkml <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org, linux-arm-kernel@...ts.arm.linux.org.uk Subject: Re: [PATCH 1/3] WAN Kconfig: change "depends on HDLC" to "select" Roman Zippel <zippel@...ux-m68k.org> writes: > Normal dependencies, you basically have to manually make sure they are > correct (and it seems with your patch they aren't). Again, _please_ (with > sugar on top) don't use select unless you have a good reason for it. You perhaps mean WAN dependency, don't you? I was under impression that the "menu" patches have already been merged so the WAN dependency would be automatic. Anything other than that? Sure, I can see now. I can only say, in my defense, that I was (and still am) very tired. I'm going to get some coffee. There is still a very good reason for the select. CONFIG_HDLC _is_ a simple library, though probably not the most simple one. I really feel it's an improvement. Attaching two patches, hopefully the double check is enough. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists