linux-kernel - Re: [PATCH] libata: fallback to the other IDENTIFY on device error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46402E7B.8090702@gmail.com>
Date:	Tue, 08 May 2007 10:02:03 +0200
From:	Tejun Heo <htejun@...il.com>
To:	William Thompson <wt@...ctro-mechanical.com>
CC:	Jeff Garzik <jgarzik@...ox.com>, Mark Lord <liml@....ca>,
	linux-kernel@...r.kernel.org,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	albertcc@...ibm.com
Subject: Re: [PATCH] libata: fallback to the other IDENTIFY on device error

William Thompson wrote:
> On Mon, May 07, 2007 at 06:42:26PM +0200, Tejun Heo wrote:
>> It seems the world isn't as frank as we thought and some devices lie
>> about who they are.  Fallback to the other IDENTIFY if IDENTIFY fails
>> with device error.  As this is the strategy used by IDE for a long
>> time, it shouldn't cause too much problem.
>>
>> Signed-off-by: Tejun Heo <htejun@...il.com>
>> Cc: William Thompson <wt@...ctro-mechanical.com>
>> ---
>> Willam, please verify this fixes your problem.  Jeff, after all, we
>> seem to need this.  :-(
> 
> Even though you have a different libata-core.c than I, the patch does work!

The different part is in libata devel tree and the rejection at the
variable declaration doesn't matter as long as you add the variable.
Thanks for testing.  :-)

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/