| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 May 2007 14:49:28 +0100 From: Russell King <rmk+lkml@....linux.org.uk> To: Linus Torvalds <torvalds@...ux-foundation.org>, Andrew Morton <akpm@...ux-foundation.org>, Linux Kernel List <linux-kernel@...r.kernel.org>, Prarit Bhargava <prarit@...hat.com>, Andi Kleen <andi@...il.nowhere.org> Subject: Please revert 86c0baf123e474b6eb404798926ecf62b426bf3a The change: +#ifdef CONFIG_HOTPLUG_CPU +#define __INIT .section ".text","ax" +#define __INITDATA .section ".data","aw" +#else #define __INIT .section ".init.text","ax" -#define __FINIT .previous #define __INITDATA .section ".init.data","aw" +#endif +#define __FINIT .previous breaks ARM, since the ARM startup code moves from the start of the image to somewhere in the middle of the kernel image. (That's trivially fixable.) Besides that, this change is also wrong because not all assembly marked __INIT needs to be moved into the standard .text segment when hotplug CPU is enabled. Ditto for __INITDATA. One is left wondering why the original patch proposers didn't: 1. Invent __CPUINIT and __CPUINITDATA, to be consistent with __init vs __cpuinit. 2. copy other architecture maintainers. Shall I invent __CPUINIT to mark data to always be thrown away, or are the x86 folk going to withdraw this patch and do it properly? -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists