linux-kernel - Re: New Mitsumi legacy CD-ROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 8 May 2007 15:53:27 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Pekka Enberg <penberg@...helsinki.fi>
Cc:	Rene Herman <rene.herman@...il.com>, Andrew Morton <akpm@...l.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: New Mitsumi legacy CD-ROM driver

On Tue, May 08 2007, Pekka Enberg wrote:
> Hi Rene,
> 
> On 5/8/07, Rene Herman <rene.herman@...il.com> wrote:
> >+static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd)
> >+{
> >+       int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1;
> >+       int retries;
> >+       int err = 0;
> >+
> >+       kfree(mcd->toc);
> >+
> >+       mcd->toc = kzalloc(tracks * sizeof *mcd->toc, GFP_KERNEL);
> 
> Perhaps we should use krealloc() + memset() here?

and sizeof(*cmd->toc) as well.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/