[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m3odkv76zy.fsf@maximus.localdomain>
Date: Tue, 08 May 2007 15:57:37 +0200
From: Krzysztof Halasa <khc@...waw.pl>
To: Michael-Luke Jones <mlj28@....ac.uk>
Cc: Jeff Garzik <jeff@...zik.org>, netdev@...r.kernel.org,
lkml <linux-kernel@...r.kernel.org>,
Russell King <rmk@....linux.org.uk>,
ARM Linux Mailing List
<linux-arm-kernel@...ts.arm.linux.org.uk>
Subject: Re: [PATCH] Intel IXP4xx network drivers v.3 - QMGR
Michael-Luke Jones <mlj28@....ac.uk> writes:
> Already in mach-ixp4xx, so can just be called qmgr.c
Same here.
>> +#define QUEUE_IRQ_SRC_NEARLY_FULL 2
>> +#define QUEUE_IRQ_SRC_FULL 3
>> +#define QUEUE_IRQ_SRC_NOT_EMPTY 4
>> +#define QUEUE_IRQ_SRC_NOT_NEARLY_EMPTY 5
>> +#define QUEUE_IRQ_SRC_NOT_NEARLY_FULL 6
>> +#define QUEUE_IRQ_SRC_NOT_FULL 7
>
> Here, unlike ixp4xx_npe.c defines are in qmgr.h - that seems a bit
> more natural.
Because they are public interface :-)
--
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists