linux-kernel - Re: New Mitsumi legacy CD-ROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020705080727o44ae55f9pfb20cf653223aa0f@mail.gmail.com>
Date:	Tue, 8 May 2007 17:27:43 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"Rene Herman" <rene.herman@...il.com>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Jens Axboe" <jens.axboe@...cle.com>,
	"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: New Mitsumi legacy CD-ROM driver

On 5/8/07, Rene Herman <rene.herman@...il.com> wrote:
> > +static int __mitsumi_read_toc(struct mitsumi_cdrom *mcd)
> > +{
> > +       int tracks = mcd->header.cdth_trk1 - mcd->header.cdth_trk0 + 1;
> > +       int retries;
> > +       int err = 0;
> > +
> > +       kfree(mcd->toc);
> > +
> > +       mcd->toc = kzalloc(tracks * sizeof *mcd->toc, GFP_KERNEL);

On 5/8/07, Pekka Enberg <penberg@...helsinki.fi> wrote:
> Perhaps we should use krealloc() + memset() here?

Strike that, krealloc() only makes it look ugly.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/