linux-kernel - Re: [PATCH 3/6] firewire: char device interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <463FBF69.3040203@redhat.com>
Date:	Mon, 07 May 2007 20:08:09 -0400
From:	Kristian Høgsberg <krh@...hat.com>
To:	Christoph Hellwig <hch@...radead.org>,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org, Kristian H??gsberg <krh@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux1394-devel <linux1394-devel@...ts.sourceforge.net>
Subject: Re: [PATCH 3/6] firewire: char device interface

Christoph Hellwig wrote:
> On Wed, May 02, 2007 at 02:17:26PM +0200, Stefan Richter wrote:
>> +#include <asm/ioctl.h>
>> +#include <asm/types.h>
> 
> Always use the <linux/ versions.

Fixed.

>> +struct fw_cdev_get_info {
>> +	/* The version field is just a running serial number.  We
>> +	 * never break backwards compatibility.  Userspace passes in
>> +	 * the version it expects and the kernel passes back the
>> +	 * highest version it can provide.  Even if the structs in
>> +	 * this interface are extended in a later version, the kernel
>> +	 * will not copy back more data than what was present in the
>> +	 * interface version userspace expects. */
>> +	__u32 version;
> 
> Please don't even try to build interfaces this complicated.  If your
> current interface needs changes at some point just introduce new ioctls.

Sure, I don't expect a lot of changes anyway, and the few features I know that 
will show up down the road are strictly additions anyway.  I think it makes 
sense to keep the version number there, though, as a way to advertise which 
ioctls are present.

Kristian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/