linux-kernel - Re: Getting make net/built-in.o Error with 2.6.21.1 Build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a781481a0705080905l609dc925s93357e6eb0d4c318@mail.gmail.com>
Date:	Tue, 8 May 2007 09:05:39 -0700
From:	"Satyam Sharma" <satyam.sharma@...il.com>
To:	"Jiri Kosina" <jikos@...os.cz>
Cc:	chris@...urn.com, linux-kernel@...r.kernel.org,
	"Marcel Holtmann" <marcel@...tmann.org>,
	bluez-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: Getting make net/built-in.o Error with 2.6.21.1 Build

Hi Jiri,

On 5/8/07, Jiri Kosina <jikos@...os.cz> wrote:
> On Tue, 8 May 2007, Satyam Sharma wrote:
>
> > >   CC      init/version.o
> > >   LD      init/built-in.o
> > >   LD      .tmp_vmlinux1
> > > net/built-in.o: In function `hidp_add_connection':
> > > (.text+0x8bb08): undefined reference to `hid_ff_init'
> > > make: *** [.tmp_vmlinux1] Error 1
> > You've got CONFIG_BT_HIDP=y there but CONFIG_USB_HID=m. The trivial
> > patch below solves it. To test, you can just "make oldconfig" on the
> > same .config that broke above and then proceed to make bzImage.
>
> I'd say we need a different fix here. First, the question is whether there
> are any force-feedback devices, supported by USBHID force-feedback layer,
> which have a bluetooth version?
>
> If there are none of them, we could just drop the FF initialization
> completely for now.
>
> On the other hand if there are such devices, just calling hid_ff_init() is
> presently not enough anyway, as the force feedback drivers for HID devices
> are currently USB-transport specific.

Sure, my aim here was to only solve the _build breakage_ by fixing the
Kconfig for this module (that used code from another kernel module
without listing it in its dependencies). If, as you say, the real
solution is that we should actually be taking out the offending call
to the other module itself, then please go ahead -- I don't know much
about the Bluetooth / HIDP subsytem anyway.

Thanks,
Satyam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/