linux-kernel - Re: [PATCH 1/2] LogFS proper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070508161703.GA18035@2ka.mipt.ru>
Date:	Tue, 8 May 2007 20:17:03 +0400
From:	Evgeniy Polyakov <johnpol@....mipt.ru>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Jan Engelhardt <jengelh@...ux01.gwdg.de>,
	Jörn Engel <joern@...ybastard.org>,
	Andrew Morton <akpm@...l.org>, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	David Chinner <dgc@....com>
Subject: Re: [PATCH 1/2] LogFS proper

On Tue, May 08, 2007 at 05:54:41PM +0200, Thomas Gleixner (tglx@...utronix.de) wrote:
> On Tue, 2007-05-08 at 14:46 +0200, Jan Engelhardt wrote:
> > >> +static int __logfs_readdir(struct file *file, void *buf, filldir_t filldir)
> > >> +{
> > >> +		err = read_dir(dir, &dd, pos);
> > >> +		if (err == -EOF)
> > >> +			break;
> > >
> > >	-EOF results in a return code 0 ?
> > 
> > Results in a return code -256.
> 
> Really ? It breaks out of the loop and returns 0 !

Likely it was done with intention - readdir returns 0 on EOF and NULL
direntry, in Jörn's code subsequent readdir call will return EOF 
again and filldir callback will not be called, so NULL will be 
returned to userspace.

-- 
	Evgeniy Polyakov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/