linux-kernel - [PATCH 2/2] V4L: v4l1-compat, fix VIDIOCSPICT for non-OVERLAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <26766101783271028925@wsc.cz>
Date:	Tue,  8 May 2007 20:25:27 +0200 (CEST)
From:	Jiri Slaby <jirislaby@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	<linux-kernel@...r.kernel.org>
Subject: [PATCH 2/2] V4L: v4l1-compat, fix VIDIOCSPICT for non-OVERLAY

v4l1-compat, fix VIDIOCSPICT for non-OVERLAY

Do not return EINVAL for devices, which don't support overlay.

Cc: Mauro Carvalho Chehab <mchehab@...radead.org>
Signed-off-by: Jiri Slaby <jirislaby@...il.com>

---
commit 637f1c324c57b002bcc94f68a1150e1ff32593c4
tree cf35d8f5990c1f335778bd85a4461c4e716daeef
parent fdc535e5e7c1b1781e903d4d21e1f657a9ac12c9
author Jiri Slaby <jirislaby@...il.com> Sun, 06 May 2007 19:48:30 +0200
committer Jiri Slaby <jirislaby@...il.com> Sun, 06 May 2007 19:48:30 +0200

 drivers/media/video/v4l1-compat.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/media/video/v4l1-compat.c b/drivers/media/video/v4l1-compat.c
index a861e15..254df73 100644
--- a/drivers/media/video/v4l1-compat.c
+++ b/drivers/media/video/v4l1-compat.c
@@ -653,8 +653,8 @@ v4l_compat_translate_ioctl(struct inode         *inode,
 			err = drv(inode, file, VIDIOC_S_FBUF, &fbuf2);
 			if (err < 0)
 				dprintk("VIDIOCSPICT / VIDIOC_S_FBUF: %d\n",err);
-			err = 0; /* likely fails for non-root */
 		}
+		err = 0; /* G_ fails for non-OVERLAY, S_ likely for non-root */
 		break;
 	}
 	case VIDIOCGTUNER: /*  get tuner information  */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/