linux-kernel - Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re: Please pull 'libertas' branch of wireless-2.6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 08 May 2007 16:59:58 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Nick Piggin <nickpiggin@...oo.com.au>
CC:	Matt Mackall <mpm@...enic.com>,
	"John W. Linville" <linville@...driver.com>,
	Dan Williams <dcbw@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	linux-wireless@...r.kernel.org, marcelo@...ck.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: Please pull 'revert-libertas' branch of wireless-2.6 (was Re:
 Please pull 'libertas' branch of wireless-2.6)

Nick Piggin wrote:
> Two things on top of a lot of people's pet peeves list are lack of
> good review bandwidth, and poor driver code! So it is sad this was
> merged without Christoph's comments being addressed. "it works for
> me, we can fix it later" is probably a big reason for quality
> problems of some parts of the kernel.
> 
> As for Christoph's idea of perfection... it usually isn't a bad
> thing. And he is quite reasonable if you explain your good reason
> to disagree or do something differently. The attitude of ignoring
> comments can be really demotivating for a reviewer.

I guess it's a good thing that the maintainer was not ignoring the 
review comments, then...

(please review the thread before replying, next time)

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/