linux-kernel - Re: [patch 3/4] split usermodehelper setup from execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070508151050.f0c2c20f.randy.dunlap@oracle.com>
Date:	Tue, 8 May 2007 15:10:50 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
	lkml <linux-kernel@...r.kernel.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	David Howells <dhowells@...hat.com>,
	Bj?rn Steinbrink <B.Steinbrink@....de>
Subject: Re: [patch 3/4] split usermodehelper setup from execution

On Tue, 08 May 2007 15:00:44 -0700 Jeremy Fitzhardinge wrote:

> Randy Dunlap wrote:
> > On Tue, 08 May 2007 13:51:32 -0700 Jeremy Fitzhardinge wrote:
> >
> >   
> >> --- a/kernel/kmod.c
> >> +++ b/kernel/kmod.c
> >> @@ -253,11 +262,94 @@ static void __call_usermodehelper(struct
> >>  }
> >>  
> >>  /**
> >> - * call_usermodehelper_keys - start a usermode application
> >> - * @path: pathname for the application
> >> - * @argv: null-terminated argument list
> >> - * @envp: null-terminated environment list
> >> - * @session_keyring: session keyring for process (NULL for an empty keyring)
> >> + * call_usermodehelper_setup - prepare to call a usermode helper
> >> + * @path - path to usermode executable
> >> + * @argv - arg vector for process
> >> + * @envp - environment for process
> >>     
> >
> > s / - /: / above please.
> >   
> 
> The power of cut'n'paste makes the errors consistent, at least...  Will
> fix up.

Thanks.  If you point me to such foobars (in general), I'll fix them up.

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/