linux-kernel - Re: [PATCH] Make bootsector stub 16-bit-only (i386)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4640F94F.5030301@zytor.com>
Date:	Tue, 08 May 2007 15:27:27 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Alexander van Heukelum <heukelum@...lshack.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	"Antonino A. Daplas" <adaplas@...il.com>, Andi Kleen <ak@...e.de>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Make bootsector stub 16-bit-only (i386)

Alexander van Heukelum wrote:
> On Tue, May 08, 2007 at 11:45:47AM -0700, H. Peter Anvin wrote:
>> Alexander van Heukelum wrote:
>>> Oh! A padding hole in a struct! That could be a problem. If the freeze
>>> is after decompression, could you test if this makes it work again?
>>>
>> The correct fix is to apply __attribute__((packed)) to this structure.
> 
> Yeah, I thought about that possibility too, but the struct didn't need
> that (in my opinion ugly) annotation before. Oh well, here you go.
> 

It did need it, however, it just "happened to work" anyway.

Yes, it's ugly, but the damage is already done.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/