[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4640FB8B.5080406@goop.org>
Date: Tue, 08 May 2007 15:36:59 -0700
From: Jeremy Fitzhardinge <jeremy@...p.org>
To: Jan Engelhardt <jengelh@...ux01.gwdg.de>
CC: Andi Kleen <ak@...e.de>, Andrew Morton <akpm@...ux-foundation.org>,
lkml <linux-kernel@...r.kernel.org>,
Chris Wright <chrisw@...s-sol.org>
Subject: Re: [patch 2/4] add argv_split()
Jan Engelhardt wrote:
> On May 8 2007 13:51, Jeremy Fitzhardinge wrote:
>
>> +
>> +static const char *skip_sep(const char *cp)
>>
>
> These are so simple they could use an 'inline' tag.
>
I'm sure the compiler can work that out for itself.
>> +#ifdef TEST
>>
>
> But not in the end result.
>
?
>> +int main() {
>> + const char *testvec[] = {
>>
>
> Suggesting static const char *const testvec[].
>
I guess, but it doesn't matter much.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists