linux-kernel - Re: [patch 3/3] clockevents: Fix resume logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2007 00:10:32 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	tglx@...utronix.de, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <johnstul@...ibm.com>
Cc:	linux-acpi@...r.kernel.org
Subject: Re: [patch 3/3] clockevents: Fix resume logic - updated version

On Tue, 8 May 2007 22:59:20 -0700 Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Sun, 06 May 2007 17:03:03 +0200 Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> > Andrew,
> > 
> > On Sat, 2007-05-05 at 13:51 +0200, Ingo Molnar wrote:
> > > * Andrew Morton <akpm@...ux-foundation.org> wrote:
> > > 
> > > > > Fixup the existing users.
> > > > 
> > > > This one makes the Vaio-of-fun hang during suspend to disk.  It gets 
> > > > up to "swsusp: critical section/: done (%d pages copied)" then it 
> > > > freezes.
> > > 
> > > after trying to reproduce it on 2 boxes without success it did trigger 
> > > some sw-suspend weirdness on a third box :) We are debugging it now.
> > 
> > find an updated patch below. It fixes the problem on Ingo's
> > VAIO-of-fun-emulator and I got confirmation from several other affected
> > users, that the patch series is still solving their problems.
> > 
> 
> The machine is still hanging with this patch applied.
> 
> suspend-to-disk gets up to "swsusp: critical section: done (NNN pages copied)"
> 
> No netconsole, no printk-timestamping.
> 
> ho hum, I guess I get to debug this.

It got ugly.

We finish swsusp_save() and a few other functions then we go

	hibernate
	->platform_finish
	  ->acpi_hibernation_finish
	    ->acpi_leave_sleep_state
	      ->acpi_evaluate_object

and there it dies, in this call:

	status = acpi_evaluate_object(NULL, METHOD_NAME__WAK, &arg_list, NULL);

I wonder how your patch caused that?

<debugs further>

OK, it gets to the last statement in acpi_evaluate_object():

	return_ACPI_STATUS(status);

but doesn't hit the printk on return to the caller,
acpi_leave_sleep_state().

A working theory would be that something we did trashed the stack in
acpi_evaluate_object().

<switches from 8k stacks to 4k. No change>

foo.  I'm not sure what to do now.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/