linux-kernel - Re: [2.6.22 PATCH 22/26] dm: bio list helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070508174159.7d78a275.akpm@linux-foundation.org>
Date:	Tue, 8 May 2007 17:41:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alasdair G Kergon <agk@...hat.com>
Cc:	dm-devel@...hat.com, linux-kernel@...r.kernel.org,
	Heinz Mauelshagen <hjm@...hat.com>
Subject: Re: [2.6.22 PATCH 22/26] dm: bio list helpers

On Tue, 8 May 2007 20:48:45 +0100
Alasdair G Kergon <agk@...hat.com> wrote:

> +#define BIO_LIST_INIT { .head = NULL, .tail = NULL }
> +
> +#define BIO_LIST(bl) \
> +	struct bio_list bl = BIO_LIST_INIT

BIO_LIST is a strange name for something which initialises storage.

>  static inline void bio_list_init(struct bio_list *bl)
>  {
>  	bl->head = bl->tail = NULL;
>  }
>  
> +#define bio_list_for_each(bio, bl) \
> +	for (bio = (bl)->head; bio && ({ prefetch(bio->bi_next); 1; }); \
> +	     bio = bio->bi_next)
> +

I have this vague memory from a long time ago that one particular CPU type
wants to go oops when prefetching from an invalid address.

Maybe that went away for some reason - we'd have hit it again if it was
real.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/