linux-kernel - Re: [patch 2/9] lguest: the guest code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020705090316o5e3b6d89r74638ec8e4d396d4@mail.gmail.com>
Date:	Wed, 9 May 2007 13:16:23 +0300
From:	"Pekka Enberg" <penberg@...helsinki.fi>
To:	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, virtualization@...ts.osdl.org,
	rusty@...tcorp.com.au, ak@...e.de, jeremy@...p.org
Subject: Re: [patch 2/9] lguest: the guest code

Hi Rusty,

On 5/9/07, akpm@...ux-foundation.org <akpm@...ux-foundation.org> wrote:
> +static void add_lguest_device(unsigned int index)
> +{
> +       struct lguest_device *new;
> +
> +       lguest_devices[index].status |= LGUEST_DEVICE_S_ACKNOWLEDGE;
> +       new = kmalloc(sizeof(struct lguest_device), GFP_KERNEL);
> +       if (!new) {
> +               printk(KERN_EMERG "Cannot allocate lguest device %u\n", index);
> +               lguest_devices[index].status |= LGUEST_DEVICE_S_FAILED;

[snip]

Any reason why we don't return an error here?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/