linux-kernel - Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070509103007.GS4163@kernel.dk>
Date:	Wed, 9 May 2007 12:30:07 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Herbert Xu <herbert@...dor.apana.org.au>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 7/10] i386 sg: add support for chaining scatterlists

On Wed, May 09 2007, Andrew Morton wrote:
> On Wed, 09 May 2007 20:03:29 +1000 Herbert Xu <herbert@...dor.apana.org.au> wrote:
> 
> > Jens Axboe <jens.axboe@...cle.com> wrote:
> > > 
> > > diff --git a/include/asm-i386/scatterlist.h b/include/asm-i386/scatterlist.h
> > > index d7e45a8..794b68c 100644
> > > --- a/include/asm-i386/scatterlist.h
> > > +++ b/include/asm-i386/scatterlist.h
> > > @@ -8,8 +8,11 @@ struct scatterlist {
> > >     unsigned int       offset;
> > >     dma_addr_t         dma_address;
> > >     unsigned int       length;
> > > +    struct scatterlist *next;
> > > };
> > 
> > BTW, the crypto layer's scatterlist already has a chaining mechanism
> > using the existing structure.  The only difference is that the chained
> > pointer is stored inside the 'struct page *' rather than a new pointer.
> 
> <greps-and-fails>
> 
> Which field in the page is it using?

crypto/scatterwalk.h:

static inline struct scatterlist *scatterwalk_sg_next(struct scatterlist
*sg)
{
        return (++sg)->length ? sg : (void *)sg->page;
}

it's just using the page pointer, not a pointer in the page structure.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/