linux-kernel - Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 9 May 2007 22:45:16 +0900 (JST)
From:	"kogiidena" <kogiidena@...plant.ddo.jp>
To:	"Richard Purdie" <rpurdie@...ys.net>
Cc:	linux-kernel@...r.kernel.org, lethal@...ux-sh.org
Subject: Re: [PATCH 2/2] leds:arch/sh/boards/landisk LEDs supports

> On Wed, 2007-05-09 at 20:42 +0900, kogiidena wrote:
>> >As far as I can tell, the existing timer trigger can do everything the
>> >blink trigger can (and more besides).
>> I want to blink LED in the initial state.
>
> Are you after to set that per LED or would some standard configurable
> default for all LEDs work?
I'm sorry.The meaning of the question cannot be understood.
My LED is use in the following.
I want to blink LED while booting it.
When boot ends, LED is turned on.

> The approach is probably a good idea but you'll have to split struct
> timer_list timer from the data structure.
>
> Also, if default_trigger wasn't the timer trigger you have a nice oops
> waiting to happen.
I'm sorry that it is not possible to understand enough.
Please teach concretely.

I think that I become more convenient if the argument can be given to "default_trigger" for "all trigger".

kogiidena
-------------------------------
 Use example -- part of leds-landisk.c
-------------------------------
static struct timer_trig_data default_timer_trig_data = {
        .delay_on  = 250,
        .delay_off = 250,
};

static struct led_classdev landisk_leds[] = {
        [0] = {
                        .name = "power",
                        .brightness_set = landisk_led_set,
                        .default_trigger = "timer",
                        .default_trigger_data = &default_timer_trig_data,
               },
        [1] = {
                        .name = "status",
                        .brightness_set = landisk_led_set,
                        .default_trigger = "timer",
                        .default_trigger_data = &default_timer_trig_data,
               },
        [2] = {

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/