linux-kernel - Re: [linux-usb-devel] Bug creating USB endpoints in 2.6.20.x (kernel bug 8198)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4641E1AF.9060201@gmail.com>
Date:	Wed, 09 May 2007 16:58:55 +0200
From:	Tejun Heo <htejun@...il.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Chris Rankin <rankincj@...oo.com>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb-devel@...ts.sourceforge.net,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Greg K-H <greg@...ah.com>, maneesh@...ibm.com,
	"cornelia.huck@...ibm.com >> Cornelia Huck" 
	<cornelia.huck@...ibm.com>
Subject: Re: [linux-usb-devel] Bug creating USB endpoints in 2.6.20.x (kernel
 bug 8198)

Dmitry Torokhov wrote:
>> As written above, I think it's better to risk module unload / sysfs race
>> than keeping the current sysfs deletion / open race.  What do you guys
>> think?
>>
> 
> How about embedding struct attribute fro devt into struct
> [class_]device for now? It is not too big and device is still going to
> be pinned into memory while there are sysfs users... I don't like
> fattening of device structures but leaks and/or oopses are worse in my
> book.

Right, your book is apparently much better than mine.  Actually, we can
just free devt_attr in device_release().  Looking at the code, class
device is already doing it that way, so here's the full-assed fix.
Chris, can you please test the attached patch?

Thanks.

-- 
tejun

View attachment "fix-devt_attr-release" of type "text/plain" (858 bytes)