linux-kernel - Re: [PATCH 1/2] Declare {compat_}sys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705091821.59412.arnd@arndb.de>
Date:	Wed, 9 May 2007 18:21:58 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	linuxppc-dev@...abs.org
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>, paulus@...ba.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Declare {compat_}sys_utimensat

On Wednesday 09 May 2007, Stephen Rothwell wrote:
> diff --git a/include/linux/compat.h b/include/linux/compat.h
> index ccd863d..70a157a 100644
> --- a/include/linux/compat.h
> +++ b/include/linux/compat.h
> @@ -253,5 +253,8 @@ asmlinkage long compat_sys_epoll_pwait(int epfd,
>                         const compat_sigset_t __user *sigmask,
>                         compat_size_t sigsetsize);
>  
> +asmlinkage long compat_sys_utimensat(unsigned int dfd, char __user *filename,
> +                               struct compat_timespec __user *t, int flags);
> +
>  #endif /* CONFIG_COMPAT */
>  #endif /* _LINUX_COMPAT_H */
> diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
> index 1912c6c..3139f44 100644
> --- a/include/linux/syscalls.h
> +++ b/include/linux/syscalls.h
> @@ -576,6 +576,8 @@ asmlinkage long sys_fstatat64(int dfd, char __user *filename,
>                                struct stat64 __user *statbuf, int flag);
>  asmlinkage long sys_readlinkat(int dfd, const char __user *path, char __user *buf,
>                                int bufsiz);
> +asmlinkage long sys_utimensat(int dfd, char __user *filename,
> +                               struct timespec __user *utimes, int flags);
>  asmlinkage long compat_sys_futimesat(unsigned int dfd, char __user *filename,
>                                      struct compat_timeval __user *t);
>  asmlinkage long compat_sys_newfstatat(unsigned int dfd, char __user * filename,

It seems bogus to declare compat_sys_futimesat in syscalls.h and compat_sys_utimensat
in compat.h. Your patch is fine, since there are precedents for both, but maybe
we should agree on one place and then move all of the compat_sys_ declarations there.

	Arnd <><
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/