linux-kernel - Re: [patch 3/3] clockevents: Fix resume logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200705091909.25443.rjw@sisk.pl>
Date:	Wed, 9 May 2007 19:09:24 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	tglx@...utronix.de
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	John Stultz <johnstul@...ibm.com>, linux-acpi@...r.kernel.org
Subject: Re: [patch 3/3] clockevents: Fix resume logic - updated version

On Wednesday, 9 May 2007 15:19, Thomas Gleixner wrote:
> On Wed, 2007-05-09 at 15:12 +0200, Rafael J. Wysocki wrote:
> > On Wednesday, 9 May 2007 14:24, Thomas Gleixner wrote:
> > > On Wed, 2007-05-09 at 13:45 +0200, Rafael J. Wysocki wrote:
> > > > On Wednesday, 9 May 2007 10:59, Thomas Gleixner wrote:
> > > > > On Wed, 2007-05-09 at 01:31 -0700, Andrew Morton wrote:
> > > > > > > I suspect I just tested the wrong thing yesterday.  Let me recheck just
> > > > > > > these patches against 2.6.21.
> > > > > > 
> > > > > > yup, same hang with just these three:
> > > > > > 
> > > > > > origin
> > > > > > clocksource-fix-resume-logic
> > > > > > clockevents-fix-resume-logic-updated-version
> > > > > 
> > > > > I have no idea, how this affects acpi_evaluate_object()
> > > > 
> > > > I think the problem is that the ACPI code ordering here is broken in a
> > > > difficult to fix way.
> > > 
> > > Any explanation aside of witchcraft why this is affected by the clock
> > > event resume changes ?
> > 
> > Well, where is unregister_time_interpolator() called from?
> 
> # grep -rn unregister_time_interpolator .
> ./kernel/timer.c:1893:unregister_time_interpolator(struct time_interpolator *ti)
> ./include/linux/timex.h:270:extern void unregister_time_interpolator(struct time_interpolator *);
> 
> I don't see a caller. i386 does not use time interpolator anyway.
> 
> # find -iname Kconfig | xargs grep TIME_INTERPOLATION
> ./arch/sparc64/Kconfig:37:config TIME_INTERPOLATION
> ./arch/ia64/Kconfig:60:config TIME_INTERPOLATION

But clocksource_resume() has no other caller, AFAICS ...

Well, I don't see any explanation that wouldn't involve witchcraft.

Rafael
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/