[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <46423D62.2070200@garzik.org>
Date: Wed, 09 May 2007 17:30:10 -0400
From: Jeff Garzik <jeff@...zik.org>
To: Chuck Lever <chuck.lever@...cle.com>,
Trond Myklebust <Trond.Myklebust@...app.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
NeilBrown <neilb@...e.de>, Adrian Bunk <bunk@...sta.de>
Subject: [bisect] NFS regression breaks X
Original bug report, with hardware and software info:
http://lkml.org/lkml/2007/5/8/667
I love bisect :) bisect has identified the following commit as the one
that causes my GNOME login to die, within 10 seconds of logging in:
commit 2bea90d43a050bbc4021d44e59beb34f384438db
Author: Chuck Lever <chuck.lever@...cle.com>
Date: Thu Mar 29 16:47:53 2007 -0400
SUNRPC: RPC buffer size estimates are too large
100% reproducible, verified regression. My home directory is an NFSv4
mount, and the problem appears on my client workstation, so this makes
some sense:
> sunrpc on /var/lib/nfs/rpc_pipefs type rpc_pipefs (rw)
> pretzel:/ on /g type nfs4 (rw,noatime,proto=tcp,addr=10.10.10.1)
As an aside, let me express the hope that the NFS developers develop
better patch creation methods. My bisect compile repeatedly died at
> CHK include/linux/version.h
> CHK include/linux/utsrelease.h
> CHK include/linux/compile.h
> fs/nfs/pagelist.c:239: error: conflicting types for ‘nfs_pageio_init’
> include/linux/nfs_page.h:80: error: previous declaration of ‘nfs_pageio_init’ was here
> make[2]: *** [fs/nfs/pagelist.o] Error 1
> make[1]: *** [fs/nfs] Error 2
> make: *** [fs] Error 2
which indicates that someone on the NFS team did not create
wholly-contained patches when submitted to the kernel. Build breakage
should not be fixed in a later commit (unless the breakage already went
upstream), because -- as we see here -- it breaks bisection.
Jeff, occasionally guilty of same, and trying to reform
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists