linux-kernel - Re: [PATCH] cpci_hotplug: Convert to use the kthread API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070509162430.772ae536.akpm@linux-foundation.org>
Date:	Wed, 9 May 2007 16:24:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Scott Murray <scottm@...anetworks.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	containers@...ts.osdl.org, Oleg Nesterov <oleg@...sign.ru>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	kristen.c.accardi@...el.com
Subject: Re: [PATCH] cpci_hotplug: Convert to use the kthread API

On Mon, 7 May 2007 14:18:29 -0400 (EDT)
Scott Murray <scottm@...anetworks.com> wrote:

> On Fri, 4 May 2007, Christoph Hellwig wrote:
> 
> > On Fri, Apr 27, 2007 at 06:07:49PM -0400, Scott Murray wrote:
> > > Sorry, it took me a few days to get to testing this out.  It looks good,    
> > > but I had to make a couple of tweaks to avoid a hang when rmmod'ing a
> > > board driver.  The board drivers do:
> > > 
> > > cpci_hp_stop()
> > > cpci_hp_unregister_controller(controller)
> > > 
> > > to shutdown, and the check in cpci_hp_unregister_controller if the thread
> > > is running wasn't working due to a bit too much code being excised.  The
> > > result was kthread_stop being called twice, which hangs.  I've indicated 
> > > my changes to avoid this inline below.
> > 
> > Can you forward the patches with your fix to Andrew to make sure he
> > picks it up?
> 
> Andrew, here is my updated version of Christoph's kthread conversion 
> patch for cpci_hotplug.  I've CC'ed Kristen so she won't be surprised
> when this eventually goes to mainline.

A patch in this area would normally go

	you->kristen->mainline
                |
                v
               -mm

or

	you->kristen->greg->mainline
                        |
                        v
                       -mm

or

	you->me->greg->mainline		(gets an Acked-by somewhere)
                   |
                   v
                  -mm

or

	you->kristen->Len->mainline
                       |
                       v
                      -mm

or something else.

Kristen, how do you want to play this?

Do you run a tree?  If so, lemmeatit ;)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/