[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070510092015.GJ4629@kernel.dk>
Date: Thu, 10 May 2007 11:20:17 +0200
From: Jens Axboe <jens.axboe@...cle.com>
To: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
hch@...radead.org
Subject: Re: [patch 10/10] Port of blktrace to the Linux Kernel Markers.
On Wed, May 09 2007, Mathieu Desnoyers wrote:
> Here is a proof of concept patch, for demonstration purpose, of moving
> blktrace to the markers.
>
> A few remarks : this patch has the positive effect of removing some code
> from the block io tracing hot paths, minimizing the i-cache impact in a
> system where the io tracing is compiled in but inactive.
>
> It also moves the blk tracing code from a header (and therefore from the
> body of the instrumented functions) to a separate C file.
>
> There, as soon as one device has to be traced, every devices have to
> fall into the tracing function call. This is slower than the previous
> inline function which tested the condition quickly. If it becomes a
> show stopper, it could be fixed by having the possibility to test a
> supplementary condition, dependant of the marker context, at the marker
> site, just after the enable/disable test.
Did you benchmark it?
--
Jens Axboe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists