[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46431D19.1070308@rtr.ca>
Date: Thu, 10 May 2007 09:24:41 -0400
From: Mark Lord <lkml@....ca>
To: Tejun Heo <htejun@...il.com>
Cc: Robert Hancock <hancockr@...w.ca>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-ide@...r.kernel.org,
Andrew Morton <akpm@...ux-foundation.org>,
Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH] libata: add human-readable error value decoding
Tejun Heo wrote:
> Robert Hancock wrote:
>> This adds human-readable decoding of the ATA status and error registers
>> (similar
>> to what drivers/ide does) as well as the SATA Serror register to libata
...
> I'm not really convinced whether this is necessary. The human readable
> form is also a bit cryptic and can get quite long. So, mild NACK from me.
Same here, but I would like to see it in there under a CONFIG_DEBUG_LIBATA
kernel build option or something. Kind of like the "FANCY_STATUS_DUMPS" flag
that drivers/ide used to have for this kind of stuff.
Cheers
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists