linux-kernel - Re: New Mitsumi legacy CD-ROM driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4643401C.2080905@gmail.com>
Date:	Thu, 10 May 2007 17:54:04 +0200
From:	Rene Herman <rene.herman@...il.com>
To:	Jens Axboe <jens.axboe@...cle.com>
CC:	Andrew Morton <akpm@...l.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: New Mitsumi legacy CD-ROM driver

On 05/08/2007 03:49 PM, Jens Axboe wrote:

> The key is that you have to have interrupts disabled for the highmem
> case, which may complicate your driver (or just make it perform worse,
> from the system POV). If you let the block layer bounce, then you can
> just use page_address() and don't worry about disabling interrupts.

Okay, yes, thank you, the mapping is gone. The data-transfer loop has now 
turned into just:

rq_for_each_bio(bio, req)
      bio_for_each_segment(bvec, bio, segno)
           ioread8_rep(mcd->ioaddr, page_address(bvec->bv_page) +
                       bvec->bv_offset, bvec->bv_len);

> - Or, it's a newer system and the nerd in you likes to play with ancient
>   CD-ROM drives.

And he has long since driven out most of my other personalities...

> Fine with me... As far as I am concerned, you are now the legacy CD-ROM
> driver maintainer :-)

Yippie :-)

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/