linux-kernel - Re: [2.6.22 PATCH 23/26] dm delay:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070510123755.09dbc70c.akpm@linux-foundation.org>
Date:	Thu, 10 May 2007 12:37:55 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Christoph Lameter <clameter@....com>
Cc:	Alasdair G Kergon <agk@...hat.com>, dm-devel@...hat.com,
	linux-kernel@...r.kernel.org,
	Heinz Mauelshagen <mauelshagen@...hat.com>
Subject: Re: [2.6.22 PATCH 23/26] dm delay:

On Thu, 10 May 2007 12:04:50 -0700 (PDT) Christoph Lameter <clameter@....com> wrote:

> On Thu, 10 May 2007, Andrew Morton wrote:
> 
> > > > +	delayed_cache = kmem_cache_create("dm-delay",
> > > > +					  sizeof(struct delay_info),
> > > > +					  __alignof__(struct delay_info),
> > > > +					  0, NULL, NULL);
> > > 
> > > We have an ugly^Wnice new KMEM_CACHE macro for this now.
> 
> How could I nicify the macro? Lower case?

Lower case would be worse, IMO.  Upper-case says "this is a macro".  Lower-case
macros are OK when they are macros pretending to be functions, but KMEM_CACHE
is not such a thing.

I don't think it can be nicified, except by removing it.  We generally
prefer to open-code things rather than wrapping them up in macros.

But given the amount of variation amongst callers and the number of times
this got screwed up, I agree that burying those details at a single site
makes sense in this instance.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/