linux-kernel - Re: slub-i386-support.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0705101328110.11759@schroedinger.engr.sgi.com>
Date:	Thu, 10 May 2007 13:31:21 -0700 (PDT)
From:	Christoph Lameter <clameter@....com>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Hugh Dickins <hugh@...itas.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <ak@...e.de>,
	William Lee Irwin III <wli@...omorphy.com>,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: slub-i386-support.patch

On Thu, 10 May 2007, Andrew Morton wrote:

> > Though when I look at the patchset (copied below), I do wonder why
> > it puts a quicklist_trim() into i386's cpu_idle() and flush_tlb_mm():
> > neither is where I'd expect us to be secretly freeing pages.  Ah,
> > several arches do it in cpu_idle(): how odd, oh well.
> 
> Christoph, could you please check that this is justified?

This has been that way for years for ia64 and sparc64. quicklist page 
freeing needs to be synced with the tlb flushing since page table pages 
may be flushed with the pages gathered in the tlb_mm struct. Dave Miller 
set this up initially as far as I can tell. He could probably give more 
details on why this was done historically.

ccing Dave.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/